Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow periodic filtering of aggregations using a tumbling window #758

Merged
merged 13 commits into from
Sep 25, 2023
Merged

feat: allow periodic filtering of aggregations using a tumbling window #758

merged 13 commits into from
Sep 25, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Sep 17, 2023 •
edited
Loading

tumbling windows are hacked using filter. This adds performance concerns regarding additional merges and filter, but it's okay for now.

Closes #759
Closes #766

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Sep 17, 2023
@github-actions github-actions bot added the enhancement New feature or request label Sep 17, 2023
bjchambers
bjchambers reviewed Sep 18, 2023
View reviewed changes
python/pysrc/kaskada/windows.py Outdated Show resolved Hide resolved
python/pysrc/kaskada/windows.py Outdated Show resolved Hide resolved
bjchambers
bjchambers approved these changes Sep 20, 2023
View reviewed changes
python/pysrc/kaskada/windows.py Show resolved Hide resolved
python/pysrc/kaskada/windows.py Outdated Show resolved Hide resolved
@jordanrfrazier
Copy link
Collaborator Author

jordanrfrazier commented Sep 21, 2023 •
edited
Loading

TODO: Investigate #766 before merging

@jordanrfrazier jordanrfrazier added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 4b8fd2f Sep 25, 2023
31 of 32 checks passed
@jordanrfrazier jordanrfrazier deleted the filter-periodically-using-filter branch September 25, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjchambers bjchambers bjchambers approved these changes

Assignees
No one assigned
Labels
cla-signed Set when all authors of a PR have signed our CLA enhancement New feature or request sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select filter not working as intended Filter periodically (with ticks)
2 participants
@jordanrfrazier @bjchambers